Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gunner goggles #2327

Merged
merged 2 commits into from
Sep 2, 2015
Merged

Fix gunner goggles #2327

merged 2 commits into from
Sep 2, 2015

Conversation

kymckay
Copy link
Member

@kymckay kymckay commented Aug 31, 2015

Fixes #1721 and #1342

Originally I introduced a canUseWeapon check to fix the FFV seats. Then when it came to considering the second issue I think it makes sense to just remove any special treatment for gunners anyway:

  • It simplifies the code and offers a slight performance benefit (that function is used by a PFH)
  • If you intend to be a vehicle gunner, you probably shouldn't be wearing unsuitable glasses anyway. Besides it's not the end of the world if you do, you can still see after all.
  • It makes things more consistent
    • Overlay already persists when using a UAV
    • Would be inconsistent for the weirdly configured commander seats/co-pilot seats
    • All the other effects checked by that function will now still take place when in a vehicle (if the vehicle goes underwater/etc.)
  • We will be introducing a client setting for the goggles overlay so nobody is forced to use it by default.

When aiming down sights, view is considered to be "gunner" and so the overlay would be disabled. Introduces addition canUseWeapon check if view is "gunner" to differentiate FFV seats from regular gunner seats
The condition to disable the overlay for gunners introduces more problems (and inconsistencies for that matter) than it was worth. Vehicle gunners using camera based weapons should probably consider not wearing a pair of glasses/goggles before doing so.
@kymckay kymckay added the kind/bug-fix Release Notes: **FIXED:** label Aug 31, 2015
@kymckay kymckay added this to the 3.3.0 milestone Aug 31, 2015
@kymckay
Copy link
Member Author

kymckay commented Aug 31, 2015

Labelled discussion as this contains a minor design decision that others might want to weigh in on

@PabstMirror
Copy link
Contributor

You can access your inventory while mounted, so this should be fine.

@kymckay
Copy link
Member Author

kymckay commented Sep 2, 2015

No objections in the past 48 hours, merging

kymckay added a commit that referenced this pull request Sep 2, 2015
@kymckay kymckay merged commit 6aa191b into master Sep 2, 2015
@kymckay kymckay deleted the fixGunnerGoggles branch September 2, 2015 12:31
@CorruptedHeart
Copy link
Member

I'm going to weigh in on this a bit late. But the original reason for it was due to the inventory not being accessible in a vehicle.

So now that, that is possible. No reason to keep it around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Goggles effect disappears when aiming as Gunner
3 participants