Code cleanup of Kestrel 4500 module #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _year = _year - 1; | ||
| }; | ||
| (_year + floor(_year/4) - floor(_year/100) + floor(_year/400) + (_table select (_month - 1)) + _day) % 7 | ||
| }; |
There was a problem hiding this comment.
Can those 2 functions be in separate files as all other functions are?
Update some Comments Fixing Spelling Issue
| * | ||
| * Public: No | ||
| */ | ||
| params ["_slot", "_value"]; |
There was a problem hiding this comment.
- Missing include
- Probably enter some empty line between params and the header.
- I don't see any reason for this code to be a global function, it could very well stay within the file where it came from, as it's not being used anywhere else apart from in
fnc_collectData.sqf
|
I can't open the Kestrel in-game. Might be due to the missing include: #2152 (comment) |
|
Fixed |
thojkooi
added a commit
that referenced
this pull request
Oct 18, 2015
Code cleanup of Kestrel 4500 module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanup of Kestrel 4500 module.