-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled pain effect while unconscious #1492
Conversation
Limited _strength to 0.1 so a player does not have to watch a flashing screen while he can't do anything about it. Otherwise we need to include a serious epilepsy warning!
It might be better to not play any pain effects while unconscious. |
It does sound way better, you can't see anything anyways... (practically). |
Yes, please. |
Ok, will change it. |
If the player is unconscious the pain effect is disabled.
@Glowbal Now the effect is disabled. |
You should use 4 spaces instead of tabs. |
I am using spaces but the diffview matches the wrong lines. Old line 167 is now at 174 |
Yeah, don't worry about it. This is just github being weird, and happens often. Unfortunately it makes code much harder to review, but tough luck. |
I will take a look at this today. |
@Glowbal Can you merge, so I can work on other stuff? |
@GitHawk that's the point of Git(Hub), make branches and you can work on infinite stuff without waiting for merges. In fact, you should really make all your pull requests on a separate (non-master) branch, do that for each feature/fix/whatever you are working on and pull request from that. |
Disabled pain effect while unconscious
Thank you @GitHawk |
Limited _strength of painEffect to 0.1 so a player does not have to watch a flashing screen while he can't do anything about it.
Otherwise we need to include a serious epilepsy warning! See http://en.wikipedia.org/wiki/Photosensitive_epilepsy