Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carrying - Clean up helper compartment #33

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Carrying - Clean up helper compartment #33

merged 3 commits into from
Apr 16, 2024

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented Apr 7, 2024 •
edited
Loading

When merged this pull request will:

@Kexanone
Clean up carrying helper
a4d88ed 
- Rename Helper to HelperCompartment
- Move static helper methods to separate ACE_CarryingTools class
- Broadcast attaching/detaching of helper
@Kexanone Kexanone added the kind/cleanup Release Notes: Excluded label Apr 7, 2024
@Kexanone Kexanone added this to the 1.0.2 milestone Apr 7, 2024
@Kexanone Kexanone changed the title Carrying - Clean up helper Carrying - Clean up helper compartment Apr 7, 2024
veteran29
veteran29 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kexanone Kexanone merged commit 09b79b6 into master Apr 16, 2024
@Kexanone Kexanone deleted the cleanup-carrying branch April 16, 2024 09:42
@Kexanone Kexanone restored the cleanup-carrying branch February 20, 2025 21:52
@Kexanone Kexanone deleted the cleanup-carrying branch February 20, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 approved these changes

Assignees
No one assigned
Labels
kind/cleanup Release Notes: Excluded
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Kexanone @veteran29