Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check whether the result is ok by testing the remote port 22 #148

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

tangmingxing1988
Copy link
Contributor

As the new firmware of 4A is not supported yet, and it seems quite sure that it won't be supported anymore as the security issue has been fixed, so it's very important to remind the user strongly, not just put it in the small corner of README. It causes the user in confusion while the result tell them everything goes well but he can't ssh. Maybe we should release a new version, as not everybody read the README very carefully.

@tangmingxing1988 tangmingxing1988 force-pushed the master branch 2 times, most recently from 0393886 to f51650e Compare September 17, 2022 13:16
@tangmingxing1988
Copy link
Contributor Author

I have tested it on my router with firmware 2.30.20, it works as expected, printing:

Warning: the process has finished, but it seems that something goes wrong.
* Maybe your firmware version is not supported, is it MiRouter 4A Gigabit 2.30.20 or 3.2.26?
* Anyway you can try it with: telnet miwifi.com

@tangmingxing1988 tangmingxing1988 changed the title check whether the result is ok by test the remote port 22 check whether the result is ok by testing the remote port 22 Sep 17, 2022
@tangmingxing1988
Copy link
Contributor Author

@acecilia Does it have any problem?

@tangmingxing1988
Copy link
Contributor Author

tangmingxing1988 commented Sep 22, 2022

@acecilia Thank you, I have changed some words as you expect, and as far as I know, socket is in the standard library so there is no need to be included in requirements.

@acecilia acecilia merged commit bac6514 into acecilia:master Sep 22, 2022
@acecilia
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants