This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Change string component creation using React.createElement in toClass function #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, good catch, please fix linting errors |
mattiaocchiuto
force-pushed
the
fix-toclass-string-component
branch
from
f5426bf to
4428db7
Compare
|
Done |
brody4hire
pushed a commit
to brodysoft/recompose
that referenced
this pull request
Feb 3, 2021
to avoid using the deprecated React.createFactory function (and update .size-snapshot.json) resolves acdlite#306
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
toClassfunction to create a component using a string it create a component with thebaseComponentvariable not resolved, so if I try to create a component calling:toClass('textarea')I will receive as output a<baseComponent>element and not a<textarea>element.