Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-markdown-editor): heading wysiwyg - #346 #359

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

d-e-v-esh
Copy link
Contributor

Signed-off-by: Devesh [email protected]

Closes #346

This is an improvement over #347

This pull request adds the feature of markdown shortcuts for headings. Now we can insert headings in the document with the help of just the #.

  • # => H1

  • ## => H2

  • ### => H3

  • #### => H4

  • ##### => H5

  • ######=> H6

  • ---, - - -, ***, * * * => PageBreak

  • This is a refactor to the feat(ui-markdown-editor): heading wysiwyg - #346 #347 which was suggested by @dselman here.

  • I could be wrong in understanding what Dan was saying. I want to get the opinions of Dan and other mentors on how to implement the structure for the matchCases so it becomes very easy to implement more matching functions later in the future.

Changes

  • A file called matchCases is added inside the utilities folder. This file is supposed to contain all the upcoming match cases that would be added i.e. code block, ordered and unordered lists, bold, italics etc.
  • A bug in the existing page break shortcut was fixed where it would keep the line where we inserted the ---.

Screenshots or Video

bJhepTiT0z

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

Copy link

@Michael-Grover Michael-Grover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I would wait for an engineer's review before merging though (like @DianaLease or @dselman)

Copy link
Member

@jolanglinais jolanglinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 🧨 !

@jolanglinais jolanglinais merged commit 72c2300 into accordproject:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heading Markdown Shortcut WYSIWYG (What You See Is What You Get)
3 participants