feat(ui-markdown-editor): heading wysiwyg - #346 #359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Devesh [email protected]
Closes #346
This is an improvement over #347
This pull request adds the feature of markdown shortcuts for headings. Now we can insert headings in the document with the help of just the
#
.# => H1
## => H2
### => H3
#### => H4
##### => H5
######=> H6
---, - - -, ***, * * * => PageBreak
This is a refactor to the feat(ui-markdown-editor): heading wysiwyg - #346 #347 which was suggested by @dselman here.
I could be wrong in understanding what Dan was saying. I want to get the opinions of Dan and other mentors on how to implement the structure for the
matchCases
so it becomes very easy to implement more matching functions later in the future.Changes
matchCases
is added inside theutilities
folder. This file is supposed to contain all the upcoming match cases that would be added i.e. code block, ordered and unordered lists, bold, italics etc.---
.Screenshots or Video
Related Issues
Author Checklist
--signoff
option of git commit.master
fromfork:branchname