Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page break shortcut does not work consistently #263

Open
Michael-Grover opened this issue Feb 23, 2021 · 6 comments · May be fixed by #270
Open

Page break shortcut does not work consistently #263

Michael-Grover opened this issue Feb 23, 2021 · 6 comments · May be fixed by #270

Comments

@Michael-Grover
Copy link

Bug Report 🐛

Using the shortcut for creating a page break (command or control + enter) only works when creating a page break after a heading.

Expected Behavior

Pressing the page break keyboard shortcut should have the same effect as clicking on the page break icon. Whenever clicking on the page break icon can create a page break, pressing the keyboard shortcut should be able to as well.

Current Behavior

The keyboard shortcut only works when creating a page break after a heading.

Steps to Reproduce

  1. Go to the markdown editor in the storybook
  2. Place your cursor after "My Heading" and press the page break shortcut on your keyboard (on mac it's cmd+enter). A page break has been created 👍
  3. Place your cursor after "This is text. This is italic text. This is bold text. This is a link. This is inline code." and press the page break shortcut on your keyboard. Nothing happens.
  4. Press the page break icon in the formatting toolbar. A page break has been created. Notice that clicking on the icon works but they keyboard shortcut does not.

Context (Environment)

Google Chrome, Macbook Pro, Mac OS Big Sur

@K-Kumar-01
Copy link
Contributor

@Michael-Grover
I would like to have a go at the issue.

@Michael-Grover
Copy link
Author

@K-Kumar-01 thanks, I've assigned it to you

@Michael-Grover
Copy link
Author

@K-Kumar-01 , I forgot that @d-e-v-esh mentioned they already started looking into this issue. Before you start on this, let's see if @d-e-v-esh would like to finish it.

@d-e-v-esh
Copy link
Contributor

d-e-v-esh commented Feb 24, 2021

@Michael-Grover I would like to really like to finish it. I looked into it for quite some time now. I'll tell you if I need some help.
Edit: I have found the issue. Working on it now. This bug seems to have been introduced from a pull request 4 months ago.

@Michael-Grover
Copy link
Author

@d-e-v-esh I've assigned it to you now, thanks 👍

@Michael-Grover
Copy link
Author

I'm going through old issues I created and it looks like this one hasn't been resolved so I'm keeping it open

d-e-v-esh added a commit to d-e-v-esh/web-components that referenced this issue Oct 31, 2021
d-e-v-esh added a commit to d-e-v-esh/web-components that referenced this issue Oct 31, 2021
d-e-v-esh added a commit to d-e-v-esh/web-components that referenced this issue Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants