Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(map): extends for Map Type #15

Merged
merged 3 commits into from
Sep 6, 2023
Merged

feat(map): extends for Map Type #15

merged 3 commits into from
Sep 6, 2023

Conversation

jonathan-casey
Copy link
Member

Changes

Extends vs-code extension for Map Type syntax highlighting

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format

@jonathan-casey
feat(map): extends for Map Type
3276c45 
Signed-off-by: jonathan.casey <[email protected]>
DS-AdamMilazzo
DS-AdamMilazzo reviewed Sep 5, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
test-data/hr/hr.cto Outdated Show resolved Hide resolved
@jonathan-casey
feat(map): indentation fix
815ae1d 
Signed-off-by: jonathan.casey <[email protected]>
@jonathan-casey
empty
ad7faf7 
Signed-off-by: jonathan.casey <[email protected]>
@jonathan-casey jonathan-casey force-pushed the jonathan/extend_vscode_for_map branch from baf9655 to ad7faf7 Compare September 5, 2023 17:33
mttrbrts
mttrbrts approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a long time since I looked at TextMate grammars. I'll trust that you have smoke tested this?
We also don't seem to have tests in this repo. 😱

@jonathan-casey
Copy link
Member Author

@mttrbrts yes, it passed the eye test, via the chrome script.

@jonathan-casey jonathan-casey merged commit ad48b80 into main Sep 6, 2023
@mttrbrts mttrbrts added this to the v3.x milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DS-AdamMilazzo DS-AdamMilazzo DS-AdamMilazzo left review comments

@mttrbrts mttrbrts mttrbrts approved these changes

@dselman dselman Awaiting requested review from dselman

@DianaLease DianaLease Awaiting requested review from DianaLease

@stefanblaginov stefanblaginov Awaiting requested review from stefanblaginov

Assignees
No one assigned
Labels
None yet
Projects
Concerto Roadmap
Status: Done
Milestone
v3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-casey @mttrbrts @DS-AdamMilazzo