This repository has been archived by the owner on May 7, 2020. It is now read-only.
feat(Error): convert array of errors to object with indexed errors - I86 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bastien Wermeille <[email protected]>
jolanglinais
requested review from
jolanglinais,
adriaan-pelzer,
DianaLease and
dselman
jolanglinais
added
Difficulty: Challenging
Hacktoberfest
adriaan-pelzer
previously approved these changes
Oct 10, 2019
|
awesome! Let's make sure we get the corresponding issue in cicero-ui resolved as well so the ErrorLogger can handle this new object. Great job! |
|
Hi @Ph0tonic! I wanted to let you know that @flagoon is working on the corresponding issue in cicero-ui here: accordproject/cicero-ui#137, so it might make sense to connect with them and see if you can test the two out together! 😃 |
jolanglinais
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
This looks good to me. Great changes! I'm going to merge this in and we can iron out any possible bugs through Cicero-UI #167
jolanglinais
changed the title
jolanglinais
suggested changes
Oct 14, 2019
|
Yes of course, here it's. |
Signed-off-by: Bastien Wermeille <[email protected]>
jolanglinais
approved these changes
Oct 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #86
Right now, the errors get added to an array every time a clause is parsed. This means if multiple changes cause a clause to be parsed multiple times, the same error will be added to the array multiple times and we end up with multiple of the same error.
Changes
Flags
Related Issues