Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core) Stricter semver check for template metadata #500

Merged
merged 1 commit into from
Dec 16, 2019
Merged

fix(core) Stricter semver check for template metadata #500

merged 1 commit into from
Dec 16, 2019

Conversation

jeromesimeon
Copy link
Member

Signed-off-by: Jerome Simeon [email protected]

Issue #499

Stricter semver check for Cicero version range and template version.

Flags

  • This is a breaking change

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.985% when pulling 37e4858 on jeromesimeon:js-fix-semver-499 into c015f23 on accordproject:release-0.21.

DianaLease
DianaLease approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@jeromesimeon jeromesimeon merged commit 65fe46d into accordproject:release-0.21 Dec 16, 2019
@jeromesimeon jeromesimeon deleted the js-fix-semver-499 branch December 19, 2019 01:09
@algomaster99 algomaster99 mentioned this pull request Mar 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DianaLease DianaLease DianaLease approved these changes

@mttrbrts mttrbrts Awaiting requested review from mttrbrts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeromesimeon @coveralls @DianaLease