Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cicero-cli and ergo-cli for 0.20 release #243

Conversation

4katie
Copy link
Contributor

@4katie 4katie commented Oct 31, 2019

Signed-off-by: Katie [email protected]

Issue #111

Updated Cicero CLI and Ergo CLIdocumentation for 0.20.0 release

Changes

  • updated commands for the new cicero-cli and ergo-cli docs
  • updated markup-cicero reflecting the changes @peterhunn made
  • changed Legal-Tech Tutorials to Beginners Tutorials

Flags

  • in ergo-cli, ergotop section, ### Calling contracts, everything from
You can then invoke clauses of the contract:

doesn't seem to work on 0.20.0 release.

Related Issues

... }
ergo$ call init(Request{})
ergo$ set contract VolumeDiscount over VolumeDiscountContract {firstVolume: 1.0, secondVolume: 10.0, firstRate: 3.0, secondRate: 2.9, thirdRate: 2.8, contractId: "0", parties: none }
ergo$ call init()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed because call init(Request{}) did not work.

All the commands below this section does not work.

Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. A few comments in the PR.

docs/markup-cicero.md Outdated Show resolved Hide resolved

The CiceroMark markup language is used to turn contracts from static, unstructured, text into structured, machine-readable, documents. Contractual documents may take one of three evolutionary forms:

1. Text: Natural language formats such as .docx or .pdf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this somewhat confusing in this section. Possibly some of that could go in the front matter or in the "Concerto Model" section, but it would require review. The term extensible isn't a very clear concept in this context. I would keep it around but remove it from this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will delete the entire ### An Extensible Framework for Contracts section for this PR. The updates can be seen from https://github.com/peterhunn/techdocs/blob/master/docs/markup-cicero.md @peterhunn

docs/ergo-cli.md Outdated Show resolved Hide resolved
@@ -695,7 +695,7 @@
"categories": {
"Introduction": "Introduction",
"Getting Started": "Getting Started",
"Legal-Tech Tutorials": "Legal-Tech Tutorials",
"Beginners Tutorials": "Beginners Tutorials",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the idea but I'm not sure I like Beginners. Maybe the distinction is between Authoring and Developing or Users vs Developers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to User Tutorials? :O

@jeromesimeon jeromesimeon self-requested a review October 31, 2019 14:21
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants