-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(concerto) Add new version of metamodel #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
mttrbrts
approved these changes
Jul 14, 2021
dselman
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! There's the TODO regarding enums, but that can be handled separately.
jeromesimeon
changed the title
feature(concero) Add new version of metamodel
feature(concerto) Add new version of metamodel
Jul 14, 2021
jeromesimeon
force-pushed
the
js-metamodel-v2
branch
3 times, most recently
from
July 16, 2021 20:29
00b4c35
to
18c1a5d
Compare
jeromesimeon
force-pushed
the
js-metamodel-v2
branch
from
July 19, 2021 12:49
18c1a5d
to
025476d
Compare
Signed-off-by: jeromesimeon <[email protected]>
Signed-off-by: jeromesimeon <[email protected]>
Signed-off-by: jeromesimeon <[email protected]>
Signed-off-by: jeromesimeon <[email protected]>
Signed-off-by: jeromesimeon <[email protected]>
Signed-off-by: jeromesimeon <[email protected]>
Signed-off-by: jeromesimeon <[email protected]>
…alid Signed-off-by: jeromesimeon <[email protected]>
jeromesimeon
force-pushed
the
js-metamodel-v2
branch
from
August 4, 2021 13:00
8c7217d
to
57148c0
Compare
Signed-off-by: jeromesimeon <[email protected]>
I'm not sure I understand that TODO (at least in the context of the current Concerto). In other word, I tried to address this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jeromesimeon [email protected]
Changes
identifier
toname
namespace.Type
andnamespace.*
Identified
andIdentifiedBy
consistent with Concerto 1.0