Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(concerto) Add new version of metamodel #137

Merged
merged 9 commits into from
Aug 4, 2021
Merged

Conversation

jeromesimeon
Copy link
Member

@jeromesimeon jeromesimeon commented Jul 14, 2021

Signed-off-by: jeromesimeon [email protected]

Changes

  • Add new version of meta model, consistent with feat(concerto): Add Model Builder visitor and example story web-components#353
  • New model adds:
    • 🐛 Fix to class declarations so they include fields!
    • 🆕 decorators to drive the new form-based editor
    • 🆕 regex checks on some of the names
  • Additional changes:
    • Rename class name field from identifier to name
    • Refactored import classes to more easily distinguish between namespace.Type and namespace.*
    • Add distinction between Identified and IdentifiedBy consistent with Concerto 1.0
    • Made type references local names rather than fully qualified names

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There's the TODO regarding enums, but that can be handled separately.

@jeromesimeon jeromesimeon changed the title feature(concero) Add new version of metamodel feature(concerto) Add new version of metamodel Jul 14, 2021
@jeromesimeon jeromesimeon force-pushed the js-metamodel-v2 branch 3 times, most recently from 00b4c35 to 18c1a5d Compare July 16, 2021 20:29
@jeromesimeon
Copy link
Member Author

LGTM! There's the TODO regarding enums, but that can be handled separately.

I'm not sure I understand that TODO (at least in the context of the current Concerto). In other word, I tried to address this.

@jeromesimeon jeromesimeon merged commit b3438c6 into master Aug 4, 2021
@jeromesimeon jeromesimeon deleted the js-metamodel-v2 branch August 4, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants