Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New transforms, CiceroEdit for migration, Tests revisions and Bug fixes #237

Merged
merged 6 commits into from
Jun 30, 2020

Conversation

jeromesimeon
Copy link
Member

@jeromesimeon jeromesimeon commented Jun 30, 2020

Changes

  • Fixes async bug in markdown-transform
  • Adds --via option to CLI, allowing to specify intermediate steps in the transform
  • Slate DOM changes:
    • clause node now include the elementType field
    • clause node only have a src field when available
    • variable nodes can also have an identifiedBy field
    • formula nodes now include dependencies and source code
  • Changes to the transform:
    • revert changes to commonmark format with wrapped variables so it is consistent with the last markdown-transform release
    • new ciceroedit with import to ciceromark which is based on the previous commonmark -> ciceromark transform. Kept around only for migration.
    • distinguishes between ciceromark and ciceromark_untyped the latter is used for ciceroedit transform.
    • commonmark -> ciceromark transform now only identifies clause nodes
    • ciceromark -> commonmark transform does not create wrap variables anymore. Remove corresponding duplicate code from markdown-template package.
  • Testing:
    • Completely revised to adjust to the new transforms. Prior tests from markdown to slate/html etc are not in the markdown-transform package.
    • CommonMark tests are split in separate files (for ciceromark, ciceroedit and the spec)

…d with conversion path, fix bug in markdown-transform, tests revisions

Signed-off-by: Jerome Simeon <[email protected]>
@jeromesimeon jeromesimeon changed the title Parserv2 New transforms, CiceroEdit for migration, Tests revisions and Bug fixes Jun 30, 2020
@coveralls
Copy link

coveralls commented Jun 30, 2020

Coverage Status

Coverage decreased (-1.2%) to 89.709% when pulling 92f89fa on parserv2 into 45d0552 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants