This repository has been archived by the owner on May 19, 2020. It is now read-only.
feat(*): implement Link modal #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diana Lease <[email protected]>
Comment on lines
-27
to
18
| const editor = useSlate(); | ||
| const { selection } = editor; | ||
| const handleMouseDown = (e) => { | ||
| e.preventDefault(); | ||
| // if (!selection) return; | ||
| toggleLink(!isLinkOpen); | ||
| ReactEditor.focus(editor); | ||
| // const url = window.prompt('Enter the URL of the link:'); | ||
| // if (!url) return; | ||
| // toggleFunc(editor, url); | ||
| }; | ||
| const isActive = activeFunc(editor, type); | ||
| const isActive = showLinkModal; | ||
| const iconColor = isActive |
There was a problem hiding this comment.
Could just get rid of isActive and use showLinkModal from props.
|
Nice. Note that I added this feature request today: Because images are just specialised links in Markdown, perhaps we can also use for to edit images? |
algomaster99
added a commit
to algomaster99/markdown-editor
that referenced
this pull request
Apr 14, 2020
Signed-off-by: Aman Sharma <[email protected]>
algomaster99
added a commit
to algomaster99/markdown-editor
that referenced
this pull request
Apr 14, 2020
Signed-off-by: Aman Sharma <[email protected]>
algomaster99
added a commit
to algomaster99/markdown-editor
that referenced
this pull request
Apr 15, 2020
…ct#296 Signed-off-by: Aman Sharma <[email protected]>
algomaster99
added a commit
to algomaster99/markdown-editor
that referenced
this pull request
Apr 15, 2020
…ct#296 Signed-off-by: Aman Sharma <[email protected]>
jolanglinais
pushed a commit
that referenced
this pull request
Apr 16, 2020
Signed-off-by: Aman Sharma <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diana Lease [email protected]
Issue #297