This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
fix(docs): Update Slack to Discord - #388 and feat(cicero): Returning the validated request -#643 #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Readme Signed-off-by: Bhavy airi <[email protected]>
Signed-off-by: tech-bash [email protected] Signed-off-by: Bhavy airi <[email protected]>
tech-bash
changed the title
5 tasks
jeromesimeon
suggested changes
Mar 17, 2022
There was a problem hiding this comment.
I'm afraid the fix won't work. I don't think validateOutput(result.request) will return the proper value. notably there is no request in the result. An alternative implementation is proposed in #866
The README changes still look good. If you update the PR, I'll merge it in.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tech-bash [email protected]
Closes #847 and #643 of the cicero issue
Changes
1- Changed slack link to discord link of ergo/readme.md
2- Added the feature of returning the validated request rather than the input one ... in engine.js .
Related Issues
Author Checklist
--signoffoption of git commit.masterfromfork:branchname