Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Fixes #391

Merged
Merged

Conversation

jeromesimeon
Copy link
Member

  • Bug in output type for default init method
  • Rename Nothing to Nil so that nil : Nil

@jeromesimeon jeromesimeon requested a review from kach August 9, 2018 02:03
@jeromesimeon jeromesimeon merged commit edc2b06 into accordproject:master Aug 9, 2018
@kach
Copy link
Contributor

kach commented Aug 10, 2018

What was wrong with just calling it Unit as you proposed? Having both Nil and Nothing types is confusing, not to mention now there's a distinction between none and nil that is hard to explain. And the word "nil" is a legal term that we shouldn't overload with Ergo-specific meaning.

@jeromesimeon
Copy link
Member Author

jeromesimeon commented Aug 10, 2018

I like unit : Unit or nil : Nil but I definitely do not like nil : Unit.

@kach
Copy link
Contributor

kach commented Aug 10, 2018

Right, I meant unit : Unit (which is what I thought your comment linked above was proposing).

@jeromesimeon
Copy link
Member Author

I actually do not like nil since it's really not the way nil is used in other languages, but you seemed to have a strong opinion about using nil. At least now the value and type is consistent.

@jeromesimeon
Copy link
Member Author

jeromesimeon commented Aug 10, 2018

Damn, I picked the wrong one :) Maybe you can make the next version with unit : Unit ? That was my favorite anyway.

@kach
Copy link
Contributor

kach commented Aug 10, 2018

Yeah okay I'm going to send a PR.

@kach
Copy link
Contributor

kach commented Aug 10, 2018

#394

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants