Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: changed the default behaviour of strictQualifiedDateTimes fix: #845 #935

Closed
wants to merge 85 commits into from

fix #552

03d7501
Select commit
Loading
Failed to load commit list.
Closed

Fix: changed the default behaviour of strictQualifiedDateTimes fix: #845 #935

fix #552
03d7501
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Nov 8, 2024 in 1s

DCO

There are 22 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~85 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin v4.0

Summary

Commit sha: 61fdc5a, Author: Dan Selman, Committer: GitHub; The sign-off is missing.
Commit sha: ad780d0, Author: DibyamAgrawal, Committer: GitHub; Can not find "DibyamAgrawal [email protected]", in ["Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]", "Dibyam Agrawal [email protected]"].
Commit sha: 425fc18, Author: Jaskeerat Singh Saluja, Committer: GitHub; Can not find "Jaskeerat Singh Saluja [email protected]", in ["Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]"].
Commit sha: fea4c91, Author: Jaskeerat Singh Saluja, Committer: GitHub; Can not find "Jaskeerat Singh Saluja [email protected]", in ["Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]"].
Commit sha: 6247c15, Author: Jaskeerat Singh Saluja, Committer: GitHub; Can not find "Jaskeerat Singh Saluja [email protected]", in ["Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]", "Jaskeerat Singh Saluja [email protected]"].
Commit sha: 1dad9ba, Author: jonathan-casey, Committer: GitHub; Expected "jonathan-casey [email protected]", but got "Jonathan Casey [email protected]".
Commit sha: fc35a40, Author: Matt Roberts, Committer: GitHub; Can not find "Matt Roberts [email protected]", in ["Matt Roberts [email protected]", "Matt Roberts [email protected]", "Matt Roberts [email protected]", "Matt Roberts [email protected]"].
Commit sha: 09eafba, Author: Matt Roberts, Committer: GitHub; Expected "Matt Roberts [email protected]", but got "Matt Roberts [email protected]".
Commit sha: e05ea3d, Author: Matt Roberts, Committer: GitHub; Can not find "Matt Roberts [email protected]", in ["Matt Roberts [email protected]", "Matt Roberts [email protected]", "Matt Roberts [email protected]"].
Commit sha: 81fa0ea, Author: Matt Roberts, Committer: GitHub; Can not find "Matt Roberts [email protected]", in ["Matt Roberts [email protected]", "Matt Roberts [email protected]", "Matt Roberts [email protected]"].
Commit sha: 8c7120f, Author: Matt Roberts, Committer: GitHub; Can not find "Matt Roberts [email protected]", in ["Matt Roberts [email protected]", "Matt Roberts [email protected]", "Matt Roberts [email protected]", "Matt Roberts [email protected]"].
Commit sha: ad762b7, Author: Matt Roberts, Committer: GitHub; Expected "Matt Roberts [email protected]", but got "Matt Roberts [email protected]".
Commit sha: 9e61044, Author: Matt Roberts, Committer: GitHub; The sign-off is missing.
Commit sha: b8c465f, Author: Muhammed Abdulkadir, Committer: GitHub; Can not find "Muhammed Abdulkadir [email protected]", in ["Moh [email protected]", "Moh [email protected]", "Moh [email protected]", "Moh [email protected]"].
Commit sha: 03d7501, Author: Sangyog Puri, Committer: Sangyog Puri; The sign-off is missing.
Commit sha: ed6c188, Author: sanket Shevkar, Committer: GitHub; Expected "sanket Shevkar [email protected]", but got "Sanket Shevkar [email protected]".
Commit sha: 08eeee5, Author: Sanket Shevkar, Committer: GitHub; Can not find "Sanket Shevkar [email protected]", in ["sanketshevkar [email protected]", "sanketshevkar [email protected]", "sanketshevkar [email protected]", "sanketshevkar [email protected]"].
Commit sha: bf3385c, Author: Sanket Shevkar, Committer: GitHub; Can not find "Sanket Shevkar [email protected]", in ["Sanket Shevkar [email protected]", "sanketshevkar [email protected]", "sanketshevkar [email protected]", "sanketshevkar [email protected]", "sanketshevkar [email protected]", "sanketshevkar [email protected]", "sanketshevkar [email protected]", "sanketshevkar [email protected]", "sanketshevkar [email protected]", "Sanket Shevkar [email protected]", "sanketshevkar [email protected]"].
Commit sha: 6758cf8, Author: Sanket Shevkar, Committer: GitHub; Expected "Sanket Shevkar [email protected]", but got "sanketshevkar [email protected]".
Commit sha: 04f606d, Author: Sanket Shevkar, Committer: GitHub; Expected "Sanket Shevkar [email protected]", but got "sanketshevkar [email protected]".
Commit sha: 769baa0, Author: Santanu Roy, Committer: GitHub; Expected "Santanu Roy [email protected]", but got "Santanu Roy [email protected]".
Commit sha: bfeb53f, Author: Subhajit Ghosh, Committer: GitHub; Can not find "Subhajit Ghosh [email protected]", in ["Subhajit Ghosh [email protected]", "Subhajit Ghosh [email protected]", "Subhajit Ghosh [email protected]", "Subhajit Ghosh [email protected]"].