Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use Globalize for error formatting #917

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

AbhinRustagi
Copy link

Closes #838

Changes

  • Added new error messages to be used by Globalize class
  • Replace hard-coded error messages with usage of Globalize Class

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Thank you!

@AbhinRustagi
Copy link
Author

Awesome, I'll update the rest of the files

@AbhinRustagi
Copy link
Author

@dselman I see that there is no consistent way that the error message code has been crafted. In some cases, it is filename-function-error_type, in others it is filename-error_type. Which one do you think should be followed for consistency? I'd vote for the first kind.

@AbhinRustagi
Copy link
Author

@dselman just following up

@dselman
Copy link
Contributor

dselman commented Oct 13, 2024

Your proposal works for me. 👌

@AbhinRustagi AbhinRustagi changed the title refactor: Update BaseModelManager to use Globalize for error formatting refactor: Use Globalize for error formatting Oct 17, 2024
Copy link
Contributor

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize/localize error messaging
2 participants