-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use Globalize for error formatting #917
base: main
Are you sure you want to change the base?
refactor: Use Globalize for error formatting #917
Conversation
Signed-off-by: AbhinRustagi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. Thank you!
Awesome, I'll update the rest of the files |
@dselman I see that there is no consistent way that the error message code has been crafted. In some cases, it is |
@dselman just following up |
Your proposal works for me. 👌 |
Signed-off-by: AbhinRustagi <[email protected]>
Signed-off-by: AbhinRustagi <[email protected]>
Signed-off-by: AbhinRustagi <[email protected]>
Signed-off-by: AbhinRustagi <[email protected]>
Signed-off-by: AbhinRustagi <[email protected]>
Signed-off-by: AbhinRustagi <[email protected]>
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Closes #838
Changes
Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:branchname