Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vocabulary): ignore empty terms #910

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix(vocabulary): ignore empty terms #910

wants to merge 5 commits into from

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Sep 23, 2024 •
edited
Loading

Changes

  • Adds a test case to DecoratorManager to ensure that it catches decorators with a null value
  • Updates the Vocabulary to filter our empty terms
  • Updates the test cases

Flags

The term for Motorcycle is ignored.

locale: en
namespace: [email protected]
declarations:
  - Motorcycle:

What should this do?

locale: en
namespace: [email protected]
declarations:
  - Motorcycle:
     description: A motor cycle
     tooltip: Motocyle

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@dselman dselman marked this pull request as draft September 23, 2024 14:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamieshorten jamieshorten jamieshorten approved these changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dselman @jamieshorten