Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(introspect): redefining imported type (#871) #901

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

salujajaskeerat
Copy link
Contributor

@salujajaskeerat salujajaskeerat commented Sep 7, 2024

Closes #871

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Jaskeerat Singh Saluja added 2 commits September 7, 2024 14:29
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
@ekarademir ekarademir changed the title fix: [redefining imported type] (#871) fix(introspect): redefining imported type (#871) Sep 18, 2024
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is system.Event etc being renamed?

@salujajaskeerat
Copy link
Contributor Author

Why is system.Event etc being renamed?

Because Event is a concerto type , in the test-case we had a name conflict with Event type being redefined

Copy link
Contributor

github-actions bot commented Dec 6, 2024

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redefining an imported type is allowed
3 participants