Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(map): fix semantic validation #841

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix(map): fix semantic validation #841

merged 1 commit into from
Apr 18, 2024

Conversation

jonathan-casey
Copy link
Member

Description

Fixes semantic validation for MapKeyTypes

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

mttrbrts
mttrbrts approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look correct, but I can't understand how this worked before! Where was the bug?

@jonathan-casey
Copy link
Member Author

@mttrbrts If you look closely at the test functions, you can actually see the facepalm in high resolution

@jonathan-casey jonathan-casey merged commit 1dad9ba into main Apr 18, 2024
11 checks passed
@jonathan-casey jonathan-casey deleted the jonathan/semantic_validation branch April 18, 2024 12:40
@jonathan-casey
Copy link
Member Author

jonathan-casey commented Apr 18, 2024 •
edited
Loading

(the IIFE was just a FE)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathan-casey @mttrbrts