Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsonpopulator) Updated processMapType to handle nested abstract c… #827

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kshitij79
Copy link

…lasses - I769

Closes #769

Changes

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test. Code looks good.

@kshitij79 kshitij79 requested a review from dselman March 21, 2024 03:32
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! Thanks @kshitij79 🎉

Signed-off-by: kshitij79 <[email protected]>
@mttrbrts mttrbrts enabled auto-merge (squash) March 27, 2024 12:16
@DianaLease
Copy link
Member

This may have been fixed in v4.x as the keys and values of maps are now treated as fields (change by @dselman ), but we should still merge this to get this fix and it's tests in now 👍

Copy link
Contributor

github-actions bot commented Dec 8, 2024

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map does not support polymorphic values
4 participants