Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error reporting when decorator manager applies a duplicate decorator #815

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

subhajit20
Copy link
Contributor

@subhajit20 subhajit20 commented Mar 9, 2024

Closes #711

  • Improved error reporting when the decorator manager applies a duplicate decorator
  • Added test for duplicate decorator

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @subhajit20, please also add a unit test for your change.

@mttrbrts mttrbrts self-requested a review March 21, 2024 13:40
@mttrbrts
Copy link
Member

@subhajit20 There are some linting errors that are causing your build to fail.

/home/runner/work/concerto/concerto/packages/concerto-core/lib/decoratormanager.js
Error:    24:39  error  Strings must use singlequote  quotes
Error:    24:76  error  Missing semicolon             semi
Error:   443:15  error  Missing semicolon             semi

Signed-off-by: Subhajit Ghosh <[email protected]>
@subhajit20
Copy link
Contributor Author

@subhajit20 There are some linting errors that are causing your build to fail.

/home/runner/work/concerto/concerto/packages/concerto-core/lib/decoratormanager.js
Error:    24:39  error  Strings must use singlequote  quotes
Error:    24:76  error  Missing semicolon             semi
Error:   443:15  error  Missing semicolon             semi

Hey I have fixed those linting error.

@subhajit20
Copy link
Contributor Author

I have added the test now.
Could you please review once you have time @mttrbrts

Copy link
Contributor

github-actions bot commented Dec 8, 2024

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error reporting when decorator manager applies a duplicate decorator
2 participants