-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vocabulary): vocaulary for map types #755
feat(vocabulary): vocaulary for map types #755
Conversation
Signed-off-by: Sanket Shevkar <[email protected]>
… sanketshevkar/vocabs-for-maps
Signed-off-by: Sanket Shevkar <[email protected]>
Signed-off-by: Sanket Shevkar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a clear example of the bug the added 'else' branch fixes, in the form of a test case and a sample command, or remove the branch entirely if it is deemed a false positive.
Signed-off-by: Sanket Shevkar <[email protected]>
Addressed. |
Signed-off-by: Sanket Shevkar <[email protected]>
Signed-off-by: Sanket Shevkar <[email protected]>
Closes #735
Changes
generateDecoratorCommand
to generate command-sets for map keys and valuesvalidate
invocabulary.js
to validate for missingTerms and Additional terms for map declarations, key and value.concerto-core
added helper methods togetNamespace
for map keys and values andisMapDeclaration
method forScalarDeclaration
Flags
KEY
VALUE
as reserved constants in concerto?Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:branchname