Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): missing array modifier for scalar fields #746

Merged
merged 7 commits into from
Oct 24, 2023
Merged

fix(core): missing array modifier for scalar fields #746

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cc05deb
Fix: missing array modifier for scalar fields
KrishnaPG Oct 23, 2023
f23aa4f
Fix: missing array modifier for scalar fields
KrishnaPG Oct 23, 2023
305e67c
Merge branch 'patch-1' of github.com:KrishnaPG/concerto into patch-1
KrishnaPG Oct 23, 2023
b7d050e
Merge branch 'patch-1' of github.com:KrishnaPG/concerto into patch-1
KrishnaPG Oct 23, 2023
75e8485
Merge branch 'patch-1' of github.com:KrishnaPG/concerto into patch-1
KrishnaPG Oct 23, 2023
b4f4e9a
Apply suggestions from code review
mttrbrts Oct 23, 2023
bf0509c
test(scalar): fix array test for scalars
mttrbrts Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/concerto-core/lib/introspect/field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ class Field extends Property {

fieldAst.name = this.ast.name;
this.scalarField = new Field(this.getParent(), fieldAst);
this.scalarField.array = this.isArray();
return this.scalarField;
}
}
Expand Down