feat(*): use modelfile to getType() #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-casey
changed the title
dselman
reviewed
Oct 20, 2023
| @@ -69,7 +69,8 @@ class MapValueType extends Decorated { | |||
| */ | |||
| validate() { | |||
| if (!ModelUtil.isPrimitiveType(this.type)) { | |||
| const decl = ModelUtil.getTypeDeclaration(this.ast.type.name, this.modelFile); | |||
|
|
|||
| const decl = this.modelFile.getType(this.ast.type.name); | |||
|
|
|||
| // All declarations, with the exception of MapDeclarations, are valid Values. | |||
There was a problem hiding this comment.
Have we got a test for enums and scalars as values?
There was a problem hiding this comment.
For Map Key yes. Coverage for imported Scalars as Values I've just added for completeness (the same function is under test).
There was a problem hiding this comment.
We don't support Enums as Map types (yet).
dselman
approved these changes
Oct 20, 2023
Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
jonathan-casey
force-pushed
the
jonathan/use_modelfile_get_type
branch
from
81fe1cc to
d3b2d52
Compare
Signed-off-by: Jonathan Casey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gets the type from the ModelFile, removes the utility function.
Author Checklist
--signoffoption of git commit.mainfromfork:branchname