fix(vocabularymanager) analysis fails with scalar. issue 723 #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Selman <[email protected]>
mttrbrts
approved these changes
Oct 2, 2023
Comment on lines
152
to
+156
| missingTerms: modelFile.getAllDeclarations().flatMap( d => this.getTerm(d.getName()) | ||
| ? d.getOwnProperties().flatMap( p => this.getTerm(d.getName(), p.getName()) ? null : `${d.getName()}.${p.getName()}`) | ||
| ? getOwnProperties(d).flatMap( p => this.getTerm(d.getName(), p.getName()) ? null : `${d.getName()}.${p.getName()}`) | ||
| : d.getName() ).filter( i => i !== null), | ||
| additionalTerms: this.content.declarations.flatMap( k => modelFile.getLocalType(Object.keys(k)[0]) | ||
| ? k.properties ? k.properties.flatMap( p => modelFile.getLocalType(Object.keys(k)[0]).getOwnProperty(Object.keys(p)[0]) ? null : `${Object.keys(k)[0]}.${Object.keys(p)[0]}`) : null | ||
| ? Array.isArray(k.properties) ? k.properties.flatMap( p => modelFile.getLocalType(Object.keys(k)[0]).getOwnProperty(Object.keys(p)[0]) ? null : `${Object.keys(k)[0]}.${Object.keys(p)[0]}`) : null |
There was a problem hiding this comment.
These ternary expressions are starting to get very difficult to read. Time for a refactor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #723
Ensures that VocabularyManager.validate works with models containing scalars.
Changes
[]Flags
Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname