Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(decoratormanager) API backwards compat #715

Merged
merged 1 commit into from
Sep 13, 2023
Merged

chore(decoratormanager) API backwards compat #715

merged 1 commit into from
Sep 13, 2023

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Sep 13, 2023 •
edited
Loading

Updates the DecoratorManager API for backwards compatibility.

Changes

  • Changes the static DecoratorManager.falsyOrEquals method to accept either a single string value, or an array or strings

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@dselman dselman marked this pull request as ready for review September 13, 2023 15:12
@dselman dselman requested a review from a team September 13, 2023 15:12
@jonathan-casey jonathan-casey merged commit 2ba977d into main Sep 13, 2023
11 checks passed
@jonathan-casey jonathan-casey deleted the ds-decoratormanager-compat branch September 13, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-casey jonathan-casey jonathan-casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dselman @jonathan-casey