Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for Decorator Command Sets #702

Merged
merged 10 commits into from
Sep 6, 2023
Merged

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Aug 31, 2023

Adds syntactic and semantic validation for decorator command sets (DCS).

Changes

  • Adds the option validate to DecoratorManager.decorateModels to validate that the DCS conforms to the model
  • Adds the option validateCommands to DecoratorManager.decorateModels to validate that the types, namespaces, declaration and properties referenced by the commands in the DCS exist in the model being decorated
  • Adds the option addMetamodel to BaseModelManager to add the Concerto metamodel to the model manager when it is constructed. This is useful for decorator command sets because they reference types from the metamodel.
  • Updates the vocabularyManager.generateDecoratorCommands to generate valid commands and to use versioned namespaces. Test has been updated to validate the input to DecoratorManager.decorateModels

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@dselman dselman requested a review from a team August 31, 2023 11:10
@dselman dselman enabled auto-merge (squash) August 31, 2023 12:56
Signed-off-by: Dan Selman <[email protected]>
@dselman dselman merged commit 1356858 into main Sep 6, 2023
@dselman dselman deleted the ds-decorator-validation branch September 6, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants