Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(decoratormanager) applying decorators to a scalar using decorator sets #700

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Aug 31, 2023

Closes #697

Fixes the DecoratorManager to allow it to apply decorators to models containing scalars.

Changes

  • Adds a check for class declarations that do not contain a properties member (like scalars)
  • Updates the unit test to include a scalar and a decorator command set that applies a decorator to a scalar

Flags

  • @jonathan-casey we should add a similar unit test for Map declarations. We will have to think about how to add decorators to the key or value properties of a map.

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@dselman dselman requested a review from a team August 31, 2023 08:50
@dselman dselman enabled auto-merge (squash) August 31, 2023 08:51
@dselman dselman merged commit d27d807 into main Aug 31, 2023
@dselman dselman deleted the ds-fix-scalar-decorators branch August 31, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DecoratorSet throws error if namespace contains scalars.
2 participants