Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Store remote models on file system #70

Merged
merged 11 commits into from
Sep 27, 2019
Merged

feat(core): Store remote models on file system #70

merged 11 commits into from
Sep 27, 2019

Conversation

mttrbrts
Copy link
Member

@mttrbrts mttrbrts commented Sep 27, 2019 •
edited
Loading

Issue #66

Support for offline download of external models

Changes

  • Adds getModels function to ModelManager
  • Adds writeModelsToFileSystem function to ModelManager
  • Exposes saveExternal function in concerto-cli

Flags

  • Also fixes a bug with the api.txt generation when hasInstance was listed as undefined

Related Issues

@mttrbrts
chore(*): Move core, tools and cli to monorepo
a6d8cea 
Signed-off-by: Matt Roberts <[email protected]>
@mttrbrts
wip(models): Adds writeModelsToFileSystem function to ModelManager
45641ea 
Signed-off-by: Matt Roberts <[email protected]>
@mttrbrts
test(modelManager): Full test coverage for getModels and writeModelsT…
30443de 
…oFileSystem

Signed-off-by: Matt Roberts <[email protected]>
@mttrbrts
chore(*): Move core, tools and cli to monorepo
14546ca 
Signed-off-by: Matt Roberts <[email protected]>
@mttrbrts
wip(models): Adds writeModelsToFileSystem function to ModelManager
502d677 
Signed-off-by: Matt Roberts <[email protected]>
@mttrbrts
test(modelManager): Full test coverage for getModels and writeModelsT…
1bf51a4 
…oFileSystem

Signed-off-by: Matt Roberts <[email protected]>
@mttrbrts
Merge branch 'mr-store-remote-models' of https://github.com/accordpro…
d7944c0 
…ject/concerto into mr-store-remote-models
@mttrbrts
chore: Revert delete root scripts
9bb69bb 
Signed-off-by: Matt Roberts <[email protected]>
@mttrbrts
test(cli): Fix getExternalModels
5c3feb4 
Signed-off-by: Matt Roberts <[email protected]>
@mttrbrts
test(modelmanager): Fix path for writeModelsToFileSystem
931cb91 
Signed-off-by: Matt Roberts <[email protected]>
@mttrbrts mttrbrts self-assigned this Sep 27, 2019
@mttrbrts mttrbrts marked this pull request as ready for review September 27, 2019 13:49
jeromesimeon
jeromesimeon reviewed Sep 27, 2019
View reviewed changes
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just couple of questions about the CLI commands, and changes to the javascript parser utility.

@mttrbrts mttrbrts merged commit 9279bd6 into master Sep 27, 2019
@mttrbrts mttrbrts deleted the mr-store-remote-models branch September 27, 2019 15:27
jeromesimeon
jeromesimeon reviewed Sep 27, 2019
View reviewed changes
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromesimeon jeromesimeon jeromesimeon left review comments

@jolanglinais jolanglinais Awaiting requested review from jolanglinais

@dselman dselman Awaiting requested review from dselman

Assignees

@mttrbrts mttrbrts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mttrbrts @jeromesimeon