Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(maps): assign key type from ast #698

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

jonathan-casey
Copy link
Member

Description

There may be scenarios where a declaration associated with a MapKeyType may not yet be available for reference within the model file, leading to an Edge case where the Key Types value cannot be set. In order to avoid this erroneous behaviour, the Type is set directly from the AST instead of the associated Declaration instance.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format

@jonathan-casey jonathan-casey requested a review from a team August 30, 2023 15:15
@jonathan-casey jonathan-casey merged commit 0623b35 into main Aug 30, 2023
@jonathan-casey jonathan-casey deleted the jonathan/patch_latent_bug_map_key branch August 30, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants