Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(introspector): getClassDeclarations filters map declarations #693

Merged
merged 2 commits into from
Aug 28, 2023
Merged

feat(introspector): getClassDeclarations filters map declarations #693

merged 2 commits into from
Aug 28, 2023

Conversation

jonathan-casey
Copy link
Member

@jonathan-casey jonathan-casey commented Aug 25, 2023 •
edited
Loading

Description

Introspector.getClassDeclarations should return ClassDeclarations only. This PR filters on declarations of type MapDeclaration.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format

@jonathan-casey jonathan-casey requested a review from a team August 25, 2023 16:38
@jonathan-casey
feat(maps): optimize on filter
f97f106 
Signed-off-by: jonathan.casey <[email protected]>
@jonathan-casey jonathan-casey merged commit 24b2515 into main Aug 28, 2023
@jonathan-casey jonathan-casey deleted the jonathan/introspector_filter_map branch August 28, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathan-casey @mttrbrts