Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): Support Import Types for Map Values #690

Merged
merged 8 commits into from
Aug 21, 2023
Merged

feat(*): Support Import Types for Map Values #690

merged 8 commits into from
Aug 21, 2023

Conversation

jonathan-casey
Copy link
Member

Changes

Supports Map Values from Types which are imported.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow [AP format]

@jonathan-casey jonathan-casey requested a review from a team August 21, 2023 15:17
mttrbrts
mttrbrts approved these changes Aug 21, 2023
View reviewed changes
packages/concerto-core/changelog.txt Outdated Show resolved Hide resolved
packages/concerto-core/types/lib/introspect/mapvaluetype.d.ts Outdated Show resolved Hide resolved
@jonathan-casey jonathan-casey merged commit 43c96e0 into main Aug 21, 2023
@jonathan-casey jonathan-casey deleted the jonathan/support_map_root_types branch August 21, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathan-casey @mttrbrts