Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(maps): patch concept serialization #688

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

jonathan-casey
Copy link
Member

Changes

Patch fix for the serialization of Concepts when used as Map values.

// Valid
{
    $class: 'org.acme.sample.Concepts',
    rolodex: {
        $class: 'org.acme.sample.Rolodex',
        'Dublin': {'$class':'org.acme.sample.Person','name':'Bob'}, // Concept is an Object
        'London': {'$class':'org.acme.sample.Person','name':'Alice'}
    }
};
// Invalid
{
    $class: 'org.acme.sample.Concepts',
    rolodex: {
        $class: 'org.acme.sample.Rolodex',
        'Dublin': '{"$class":"org.acme.sample.Person","name":"Bob"}',  // Concept is not a String
        'London': '{"$class":"org.acme.sample.Person","name":"Alice"}'
    }
};

@jonathan-casey jonathan-casey requested a review from a team August 17, 2023 13:51
@jonathan-casey jonathan-casey merged commit 3fa0135 into main Aug 17, 2023
@jonathan-casey jonathan-casey deleted the jonathan/map-concepts-patch-serializer branch August 17, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant