fix(filter) : remove imports of filtered types #683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #682
Updates the
BaseModelManager.filter
method to update all the imports in the model manager based on the types that were removed by calls toModelFiler.filter
.Changes
Flags
removedDeclarations
as an extra argument is technically a breaking change however if we assume that the only caller of this function is BaseModelManager then we could argue that this is a pure bug fix.ModelFiles with no declarations after filtering will be removed.
— I suspect this could break wildcard imports when Concerto is used withstrict:false
. I'm choosing to ignore this given folks should be usingstrict:true
and the likelihood that they are not and also usingfilter
is small.Screenshots or Video
Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:branchname