Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vocab): add imports for typescript generation #657

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

mttrbrts
Copy link
Member

@mttrbrts mttrbrts commented Jun 7, 2023

Fixes an issue found in accordproject/concerto-codegen#22 (comment)

The concerto-vocabulary does not generate valid TypeScript type definitions because it was missing some imports.

I also bump some internal dependencies, migrate from concerto-tools to concerto-codegen

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mttrbrts mttrbrts enabled auto-merge (squash) June 7, 2023 12:27
@mttrbrts mttrbrts merged commit 9e000d6 into accordproject:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants