feat(*): MapDeclaration Parse & Print #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jonathan.casey <[email protected]>
Signed-off-by: jonathan.casey <[email protected]>
Signed-off-by: jonathan.casey <[email protected]>
Signed-off-by: jonathan.casey <[email protected]>
Signed-off-by: jonathan.casey <[email protected]>
jonathan-casey
force-pushed
the
jcasey/map_declaration_grammar_rules
branch
from
8f4d36e to
3b37465
Compare
Signed-off-by: jonathan.casey <[email protected]>
mttrbrts
changed the title
mttrbrts
requested changes
Apr 26, 2023
packages/concerto-core/types/lib/serializer/resourcevalidator.d.ts
Outdated
Show resolved
Hide resolved
…n as top level declaration Signed-off-by: jonathan.casey <[email protected]>
Signed-off-by: jonathan.casey <[email protected]>
Signed-off-by: jonathan.casey <[email protected]>
jonathan-casey
force-pushed
the
jcasey/map_declaration_grammar_rules
branch
from
4296b3f to
f05a205
Compare
Signed-off-by: jonathan.casey <[email protected]>
Signed-off-by: jonathan.casey <[email protected]>
Signed-off-by: jonathan.casey <[email protected]>
Signed-off-by: jonathan.casey <[email protected]>
Signed-off-by: jonathan.casey <[email protected]>
Signed-off-by: jonathan.casey <[email protected]>
mttrbrts
approved these changes
May 10, 2023
ragi-dayananda
pushed a commit
to ragi-dayananda/concerto
that referenced
this pull request
May 22, 2023
* feat(*): add grammar rules for MapDeclaration Signed-off-by: jonathan.casey <[email protected]> * feat(*): add MapDeclaration case to Printer Signed-off-by: jonathan.casey <[email protected]> * feat(*): add cto & ast test data, for Parse & Print tests Signed-off-by: jonathan.casey <[email protected]> * feat(*): type definitions updated Signed-off-by: jonathan.casey <[email protected]> * chore(*): package-lock update Signed-off-by: jonathan.casey <[email protected]> * feat(*): fix JSDoc Signed-off-by: jonathan.casey <[email protected]> * feat(*): remove MapPropertyKeyDeclaration & MapPropertValueDeclaration as top level declaration Signed-off-by: jonathan.casey <[email protected]> * test(*): decorators on map top level and props Signed-off-by: jonathan.casey <[email protected]> * test(*): negative case for map type - too many properties Signed-off-by: jonathan.casey <[email protected]> * feat(*): add MapRelationshipPropertyValue Signed-off-by: jonathan.casey <[email protected]> * test(*): add more test cov Signed-off-by: jonathan.casey <[email protected]> * feat(*): parser.js update Signed-off-by: jonathan.casey <[email protected]> * feat(*): AST rename Signed-off-by: jonathan.casey <[email protected]> * feat(*): printer evaluates AggregateRelationshipValueType Signed-off-by: jonathan.casey <[email protected]> * feat(*): update test data Signed-off-by: jonathan.casey <[email protected]> * feat(*): cleanup * feat(*): cleanup * feat(*): update parser.js --------- Signed-off-by: jonathan.casey <[email protected]> Signed-off-by: [email protected] <[email protected]>
mttrbrts
added a commit
that referenced
this pull request
May 22, 2023
* feat(*): MapDeclaration Parse & Print (#641) * feat(*): add grammar rules for MapDeclaration Signed-off-by: jonathan.casey <[email protected]> * feat(*): add MapDeclaration case to Printer Signed-off-by: jonathan.casey <[email protected]> * feat(*): add cto & ast test data, for Parse & Print tests Signed-off-by: jonathan.casey <[email protected]> * feat(*): type definitions updated Signed-off-by: jonathan.casey <[email protected]> * chore(*): package-lock update Signed-off-by: jonathan.casey <[email protected]> * feat(*): fix JSDoc Signed-off-by: jonathan.casey <[email protected]> * feat(*): remove MapPropertyKeyDeclaration & MapPropertValueDeclaration as top level declaration Signed-off-by: jonathan.casey <[email protected]> * test(*): decorators on map top level and props Signed-off-by: jonathan.casey <[email protected]> * test(*): negative case for map type - too many properties Signed-off-by: jonathan.casey <[email protected]> * feat(*): add MapRelationshipPropertyValue Signed-off-by: jonathan.casey <[email protected]> * test(*): add more test cov Signed-off-by: jonathan.casey <[email protected]> * feat(*): parser.js update Signed-off-by: jonathan.casey <[email protected]> * feat(*): AST rename Signed-off-by: jonathan.casey <[email protected]> * feat(*): printer evaluates AggregateRelationshipValueType Signed-off-by: jonathan.casey <[email protected]> * feat(*): update test data Signed-off-by: jonathan.casey <[email protected]> * feat(*): cleanup * feat(*): cleanup * feat(*): update parser.js --------- Signed-off-by: jonathan.casey <[email protected]> Signed-off-by: [email protected] <[email protected]> * chore(deps): bump yaml from 2.0.0-9 to 2.2.2 in /packages/concerto-vocabulary (#640) chore(deps): bump yaml in /packages/concerto-vocabulary Bumps [yaml](https://github.com/eemeli/yaml) from 2.0.0-9 to 2.2.2. - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v2.0.0-9...v2.2.2) --- updated-dependencies: - dependency-name: yaml dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: [email protected] <[email protected]> * Support string length validation in concerto core Signed-off-by: [email protected] <[email protected]> * instance generator changes enhance edge cases for string validator Signed-off-by: [email protected] <[email protected]> * enhance test cases and update compare tests Signed-off-by: [email protected] <[email protected]> * add test cases for concerto-analysis Signed-off-by: [email protected] <[email protected]> * docs(readme): fix badges Signed-off-by: [email protected] <[email protected]> --------- Signed-off-by: jonathan.casey <[email protected]> Signed-off-by: [email protected] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jonathan-Casey <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matt Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
The implementation of the map declaration feature will be delivered incrementally through a phased approach. The first phase involves updating the parser grammar, & enabling both Parse and Print for map types. As part of this process, test data for both the cto and ast representation of a map declaration is added to test the print and parse functionalities.
At its core, a
MapDeclarationconsists of oneMapKeyTypeand a generalAggregateValueType, which may in some cases be specialized to anAggregateRelationshipValueType—both of which may be annotated, as too can the parent declaration.For more information on the design specification see here
Changes
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname