Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UUID format fix for jsonschema visitor #635

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

ragi-dayananda
Copy link
Contributor

Changes

JSON schema for CTO model generates the referential type to be "string" with appropriate referent type. However, it should also support the "identified by" type format for "uuid"

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@ragi-dayananda ragi-dayananda requested a review from a team April 17, 2023 10:56
Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also handle adding the UUID format to non relationship UUID scalars?

@ragi-dayananda
Copy link
Contributor Author

Do we also handle adding the UUID format to non relationship UUID scalars?

@dselman no, we haven't handled that in this PR. Good catch, let me add it.

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@dselman dselman merged commit c8f7ae6 into accordproject:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants