Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): issue when converting a valid model to Protobuf #618

Merged

Conversation

stefanblaginov
Copy link
Contributor

@stefanblaginov stefanblaginov commented Mar 8, 2023

Closes #617

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@stefanblaginov stefanblaginov requested review from a team and dselman March 8, 2023 18:33
@mttrbrts mttrbrts enabled auto-merge (squash) March 8, 2023 18:37
@dselman
Copy link
Contributor

dselman commented Mar 8, 2023

Test is failing due to a CR/LF line feed issue on Windows:

AssertionError: expected 'syntax = "proto3";\n\npackage concert…' to equal 'syntax = "proto3";\r\n\r\npackage con…'

@stefanblaginov stefanblaginov force-pushed the stefanblaginov/protobuf-bug-fix branch from 370b352 to 842fdcf Compare March 9, 2023 09:42
@stefanblaginov
Copy link
Contributor Author

Test is failing due to a CR/LF line feed issue on Windows:

AssertionError: expected 'syntax = "proto3";\n\npackage concert…' to equal 'syntax = "proto3";\r\n\r\npackage con…'

Thanks @dselman , I had forgotten about that quirk! Addressed ✅

Stefan Blaginov added 2 commits March 9, 2023 10:23
@stefanblaginov stefanblaginov force-pushed the stefanblaginov/protobuf-bug-fix branch from 5e2760a to 311b272 Compare March 9, 2023 10:28
Signed-off-by: Stefan Blaginov <[email protected]>
@stefanblaginov stefanblaginov force-pushed the stefanblaginov/protobuf-bug-fix branch from ac192dd to 0b046a1 Compare March 9, 2023 10:40
Stefan Blaginov added 3 commits March 9, 2023 10:51
…dows CR/LF behaviour

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>
@stefanblaginov stefanblaginov force-pushed the stefanblaginov/protobuf-bug-fix branch from 1616e7a to eb40bc9 Compare March 9, 2023 11:14
@mttrbrts mttrbrts merged commit a52af54 into accordproject:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concerto to Protobuf generation fails when using APAP models
3 participants