-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tools): issue when converting a valid model to Protobuf #618
Merged
mttrbrts
merged 8 commits into
accordproject:main
from
stefanblaginov:stefanblaginov/protobuf-bug-fix
Mar 9, 2023
Merged
fix(tools): issue when converting a valid model to Protobuf #618
mttrbrts
merged 8 commits into
accordproject:main
from
stefanblaginov:stefanblaginov/protobuf-bug-fix
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Blaginov <[email protected]>
mttrbrts
approved these changes
Mar 8, 2023
Test is failing due to a CR/LF line feed issue on Windows:
|
Signed-off-by: Stefan Blaginov <[email protected]>
stefanblaginov
force-pushed
the
stefanblaginov/protobuf-bug-fix
branch
from
March 9, 2023 09:42
370b352
to
842fdcf
Compare
Thanks @dselman , I had forgotten about that quirk! Addressed ✅ |
…ndows Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>
stefanblaginov
force-pushed
the
stefanblaginov/protobuf-bug-fix
branch
from
March 9, 2023 10:28
5e2760a
to
311b272
Compare
Signed-off-by: Stefan Blaginov <[email protected]>
stefanblaginov
force-pushed
the
stefanblaginov/protobuf-bug-fix
branch
from
March 9, 2023 10:40
ac192dd
to
0b046a1
Compare
…dows CR/LF behaviour Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>
stefanblaginov
force-pushed
the
stefanblaginov/protobuf-bug-fix
branch
from
March 9, 2023 11:14
1616e7a
to
eb40bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #617
Author Checklist
--signoff
option of git commit.main
fromfork:branchname