Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): enum, regex, referential type feature for csharp codegen #607

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

ragi-dayananda
Copy link
Contributor

@ragi-dayananda ragi-dayananda commented Feb 15, 2023

Changes

  • Add regex annotation for csharp codegen when regex configured for a field
  • UUID nullable type bug fix
  • Make optional string properties as nullable string.
  • Custom enum value support with AcceptedValue decorator
  • Handle referential type (-->) in csharp codegen

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@ragi-dayananda ragi-dayananda requested a review from a team February 15, 2023 16:50
@@ -283,8 +284,17 @@ class CSharpVisitor {

let fieldType = externalFieldType ? externalFieldType : this.getFieldType(field);

if (fieldType === 'String') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry that we might be using an externalFieldType here...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we might. But external type can be UUID scalar type. We don't want to add regex decorator for UUID.

@ragi-dayananda ragi-dayananda changed the title feat(tools): decorate regex for csharp codegen feat(tools): enum, regex, referential type feature for csharp codegen Apr 13, 2023
Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dselman dselman merged commit 3213757 into accordproject:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants