Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tools): Support for more dotnet built-in types #605

Merged
merged 2 commits into from
Feb 10, 2023
Merged

feat(tools): Support for more dotnet built-in types #605

merged 2 commits into from
Feb 10, 2023

Conversation

ragi-dayananda
Copy link
Contributor

@ragi-dayananda ragi-dayananda commented Feb 9, 2023 •
edited
Loading

Signed-off-by: [email protected] [email protected]

Changes

  • Support more csharp built in data types using @DotNetType annotation.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@ragi-dayananda ragi-dayananda requested a review from a team February 9, 2023 16:22
@dselman
Copy link
Contributor

dselman commented Feb 9, 2023 •
edited
Loading

I think I understand how this will be used for codegen - but what does it mean for serialisation and deserialisation? @ragi-dayananda

@dselman dselman merged commit 30590fc into accordproject:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts left review comments

@dselman dselman dselman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ragi-dayananda @dselman @mttrbrts