Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JSON Schema generation improvements for base types #592 #593

Merged
merged 2 commits into from
Jan 17, 2023
Merged

fix: JSON Schema generation improvements for base types #592 #593

merged 2 commits into from
Jan 17, 2023

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Jan 17, 2023

Signed-off-by: Dan Selman [email protected]

Closes #592

Updates the JSON Schema visitor to include an anyOf for polymorphic types.

Changes

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@dselman dselman requested a review from a team January 17, 2023 17:21
@dselman dselman merged commit eb52489 into main Jan 17, 2023
@dselman dselman deleted the ds-jsonschema-inheritence branch January 17, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON Schema generation improvements for base types
2 participants
@dselman @mttrbrts