Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(core): fix system time offset for tests #590

Merged
merged 3 commits into from
Jan 17, 2023
Merged

test(core): fix system time offset for tests #590

merged 3 commits into from
Jan 17, 2023

Conversation

mttrbrts
Copy link
Member

Unit tests would previously fail when run in an environment with a non-zero UTC offset.
This change explicitly sets the offset to UTC+0 so that the unit tests are more stable.

@mttrbrts mttrbrts requested a review from a team January 17, 2023 13:33
dselman
dselman reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to update package.json to set TZ?

@mttrbrts mttrbrts enabled auto-merge (squash) January 17, 2023 13:51
@mttrbrts mttrbrts merged commit a8d311c into accordproject:main Jan 17, 2023
@mttrbrts mttrbrts deleted the mr-test-tz-offset-warn branch January 17, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dselman dselman dselman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mttrbrts @dselman