Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tools): improve JSON schema inference #549

Merged
merged 1 commit into from
Nov 18, 2022
Merged

feat(tools): improve JSON schema inference #549

merged 1 commit into from
Nov 18, 2022

Conversation

mttrbrts
Copy link
Member

@mttrbrts mttrbrts commented Nov 17, 2022 •
edited
Loading

  • Relaxes error handling to quietly warn users of issues. This allows users to manually rectify issues.
  • Basic support for oneOf alternatives (fallback to first alternative)
  • Basic support for plain object types (defaults to String type, to allow serialisation.

@mttrbrts mttrbrts requested a review from a team November 17, 2022 16:47
@mttrbrts
feat(tools): improve JSON schema inference
a4c4989 
Signed-off-by: Matt Roberts <[email protected]>

fix(tools): missing param definition in inferModel

refactor(tools): tidy up inferModel code

fix(cli): remove duplicate require

Signed-off-by: Matt Roberts <[email protected]>

test(cli): update to match new infer logic

Signed-off-by: Matt Roberts <[email protected]>
@dselman dselman merged commit c4919a1 into accordproject:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dselman dselman dselman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mttrbrts @dselman