feat(*): extend concerto compare to include field validators #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Stone <[email protected]>
Signed-off-by: Simon Stone <[email protected]>
dselman
approved these changes
Aug 9, 2022
| @@ -43,3 +43,13 @@ export function getPropertyType(property: Property) { | |||
| throw new Error(`unknown property type "${property}"`); | |||
| } | |||
| } | |||
|
|
|||
| export function getValidatorType(validator: Validator) { | |||
| if (validator instanceof NumberValidator) { | |||
There was a problem hiding this comment.
Probably not applicable here - but we've been bitten by using instanceof for exported types, as instanceof also checks the module for the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
concerto compareso that it can compare number and string validators attached to a field.This will catch:
Note that for regexes, it may be possible to make a regex more lenient than it was before, but there is no way for us to programmatically assert that one regex is more lenient than another regex.