Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): handle more differences in concerto models (contributes to #442) #477

Merged
merged 4 commits into from
Aug 5, 2022

Conversation

sstone1
Copy link
Contributor

@sstone1 sstone1 commented Aug 5, 2022

Adds detection of the following differences in Concerto models:

  • Declaration type changed (concept changed to asset, asset changed to enum, etc)
  • Enum value added to an enum
  • Enum value removed from an enum
  • Field changed to relationship (o Bar bar to --> Bar bar) and vice versa
  • Scalar field/relationship changed to array field/relationship (o String value to o String[] value) and vice versa
  • Primitive field changed to declaration typed field (o String value to o Bar value) and vice versa
  • Namespace of declaration typed field changed (com.example.Bar to com.example.other.Bar)
  • Namespace version of declaration typed field incompatibly changed ([email protected] to [email protected])

@sstone1 sstone1 requested review from dselman and mttrbrts August 5, 2022 18:49
@sstone1 sstone1 self-assigned this Aug 5, 2022
@sstone1 sstone1 enabled auto-merge (rebase) August 5, 2022 18:49
@sstone1 sstone1 merged commit 8645a0c into accordproject:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant