Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) remove unused config mediator, causing webpack issues? #473

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Aug 3, 2022

Signed-off-by: Dan Selman [email protected]

Removes the unused ConfigMediator class from Concerto core, which uses the process variable, which seems to be causing issues with the latest version of create-react-app and web pack.

Changes

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

@dselman dselman requested review from mttrbrts and sstone1 August 3, 2022 15:53
@dselman dselman merged commit 0cbce7a into master Aug 3, 2022
@dselman dselman deleted the ds-config-mediator branch August 3, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants