Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Distinguish Model Manager on CTO or AST, revise addModel operations #397

Merged
merged 8 commits into from
Mar 16, 2022

Conversation

jeromesimeon
Copy link
Member

@jeromesimeon jeromesimeon commented Mar 10, 2022

Signed-off-by: Jerome Simeon [email protected]

Changes

  • Further clean up CTO dependent code
    • Remove parser dependency in MetaModel module in core
    • Distinguish addModelFile (over AST) and addCTOfile (over CTO) in the model manager
    • concerto-core now depends only on AST versions rather than CTO versions of the two built in models: namespace concerto and namespace concerto.metamodel
  • New BaseModelManager is Concerto AST-only dependent while legacy ModelManager supports full CTO syntax. The two model managers only differ in how they process input files. Only the legacy ModelManager depends on the CTO parser.

Flags

  • Further work would still be needed to be able to fully reverse the dependency from core to cto:
    • Move legacy ModelManager into @concerto-cto and reverse the dependency from concerto-core to concerto-to
    • Adjust the ModelLoader class accordingly or move it
    • Update all the tests that still depend on CTO syntax in concerto-core to rely on the AST instead -- big change but conceptually simple

@jeromesimeon jeromesimeon marked this pull request as ready for review March 15, 2022 16:37
@jeromesimeon jeromesimeon changed the title refactor(core): Further isolate the parser from concerto-core refactor(core): Distinguish Model Manager on CTO or AST, revise addModel operations Mar 15, 2022
@jeromesimeon jeromesimeon force-pushed the js-refactor-cto-again branch from a7665fd to f2e6ac8 Compare March 15, 2022 18:23
Signed-off-by: Jerome Simeon <[email protected]>
@jeromesimeon jeromesimeon force-pushed the js-refactor-cto-again branch from e015590 to 688fe74 Compare March 15, 2022 18:50
@jeromesimeon jeromesimeon merged commit cbfa5fd into accordproject:master Mar 16, 2022
@jeromesimeon jeromesimeon deleted the js-refactor-cto-again branch March 16, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant