refactor(core): Distinguish Model Manager on CTO or AST, revise addModel operations #397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jerome Simeon [email protected]
Changes
addModelFile
(over AST) andaddCTOfile
(over CTO) in the model managerconcerto-core
now depends only on AST versions rather than CTO versions of the two built in models:namespace concerto
andnamespace concerto.metamodel
BaseModelManager
is Concerto AST-only dependent while legacyModelManager
supports full CTO syntax. The two model managers only differ in how they process input files. Only the legacyModelManager
depends on the CTO parser.Flags
ModelManager
into@concerto-cto
and reverse the dependency fromconcerto-core
toconcerto-to
ModelLoader
class accordingly or move itconcerto-core
to rely on the AST instead -- big change but conceptually simple